Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(screenshots): added parameter and deprecation warning #173

Merged
merged 1 commit into from
Oct 2, 2024
Merged

feat(screenshots): added parameter and deprecation warning #173

merged 1 commit into from
Oct 2, 2024

Conversation

OmAximani0
Copy link
Contributor

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 99.20%. Comparing base (f21813f) to head (683824d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crowdin_api/api_resources/screenshots/resource.py 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
- Coverage   99.25%   99.20%   -0.04%     
==========================================
  Files         166      166              
  Lines        6450     6454       +4     
  Branches      876      877       +1     
==========================================
+ Hits         6401     6402       +1     
- Misses         34       36       +2     
- Partials       15       16       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

andrii-bodnar
andrii-bodnar approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OmAximani0 thank you!

@andrii-bodnar andrii-bodnar merged commit 16ce5de into crowdin:main Oct 2, 2024
6 checks passed
@OmAximani0 OmAximani0 deleted the feat/screenshots-lists-api branch October 7, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrii-bodnar andrii-bodnar andrii-bodnar approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Screenshots APIs: add the stringIds parameter support
3 participants
@OmAximani0 @codecov-commenter @andrii-bodnar